Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions acceptance/acceptance_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -411,6 +411,10 @@ func getSkipReason(config *internal.TestConfig, configPath string) string {
return "Disabled via SkipLocal setting in " + configPath
}

if isTruePtr(config.SkipOnDbr) && WorkspaceTmpDir {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question - is intentionally placed before Forcerun check?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, no it's not. Fixed in #3552

return "Disabled via SkipOnDbr setting in " + configPath
}

if Forcerun {
return ""
}
Expand Down
14 changes: 14 additions & 0 deletions acceptance/bundle/artifacts/test.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,18 @@
RecordRequests = true

# Workspace file system does not allow initializing python envs on it.
# I suspect something about the default python env on DBR interferes with it.
# We'll likely need a first class venv abstraction in acceptance tests to fix this.
# script:
# uv venv -q .venv
# source .venv/bin/activate
# uv pip install -q setuptools
# error:
# Failed to inspect Python interpreter from active virtual environment at `.venv/bin/python3`
# Caused by: Failed to query Python interpreter
# Caused by: failed to canonicalize path `/Workspace/abcd/.venv/bin/python3`: Invalid cross-device link (os error 18)
SkipOnDbr = true

Ignore = [
'.venv',
'dist',
Expand Down
13 changes: 13 additions & 0 deletions acceptance/bundle/integration_whl/test.toml
Original file line number Diff line number Diff line change
@@ -1,6 +1,19 @@
Local = false
CloudSlow = true

# Workspace file system does not allow initializing python envs on it.
# I suspect something about the default python env on DBR interferes with it.
# We'll likely need a first class venv abstraction in acceptance tests to fix this.
# script:
# uv venv -q .venv
# source .venv/bin/activate
# uv pip install -q setuptools
# error:
# Failed to inspect Python interpreter from active virtual environment at `.venv/bin/python3`
# Caused by: Failed to query Python interpreter
# Caused by: failed to canonicalize path `/Workspace/abcd/.venv/bin/python3`: Invalid cross-device link (os error 18)
SkipOnDbr = true

Ignore = [
".databricks",
".venv",
Expand Down
3 changes: 3 additions & 0 deletions acceptance/internal/config.go
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ type TestConfig struct {
// Null means "databricks.yml"
BundleConfigTarget *string

// If true, skip this test when running on DBR / workspace file system.
SkipOnDbr *bool

// To be added:
// BundleConfigMatrix is to BundleConfig what EnvMatrix is to Env
// It creates different tests for each possible configuration update.
Expand Down
Loading