Skip to content

Conversation

@denik
Copy link
Contributor

@denik denik commented Sep 4, 2025

Changes

  • Increase HTTPTimeoutSeconds from 30s to 90s
  • Increase RetryTimeoutSeconds from 5m to 15m

Why

We saw an issue where "bundle deploy" dies during upload of 1.4Mb file with "request timed out after 30s of inactivity". We'd rather see the backend raise the error.

Tests

New test that records what happens during timeout. Incidentally it shows that retries do not work.

Another test shows what happens for 500, just for completeness.

@denik denik temporarily deployed to test-trigger-is September 4, 2025 12:51 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Sep 4, 2025

Run: 17466483406

Env ✅​pass 🔄​flaky 🙈​skip
✅​ aws linux 308 518
✅​ aws windows 309 517
✅​ aws-ucws linux 420 416
✅​ aws-ucws windows 421 415
✅​ azure linux 308 517
✅​ azure windows 309 516
🔄​ azure-ucws linux 418 2 415
✅​ azure-ucws windows 421 414
✅​ gcp linux 307 519
✅​ gcp windows 308 518
Test Name azure-ucws linux
TestAccept 🔄​flaky
TestAccept/bundle/deployment/bind/dashboard 🔄​flaky

@denik denik temporarily deployed to test-trigger-is September 4, 2025 13:06 — with GitHub Actions Inactive
@@ -0,0 +1,5 @@
Uploading bundle files to /Workspace/Users/[USERNAME]/.bundle/test-bundle/default/files...
Error: Post "[DATABRICKS_URL]/api/2.0/workspace-files/import-file/Workspace%2FUsers%2F[USERNAME]%2F.bundle%2Ftest-bundle%2Fdefault%2Ffiles%2Ffile_to_upload.txt?overwrite=true": request timed out after 30s of inactivity
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this not say 90s?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Fixed in f08ca62


Endpoint: POST [DATABRICKS_URL]/api/2.0/workspace-files/import-file/Workspace%2FUsers%2F[USERNAME]%2F.bundle%2Ftest-bundle%2Fdefault%2Ffiles%2Ffile_to_upload.txt?overwrite=true
HTTP Status: 500 Internal Server Error
API error_code:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the whitespace line. We could write <empty> as placeholder if there is no value.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense, it's on my list to improve this message to handle different error outputs better.

@denik denik temporarily deployed to test-trigger-is September 4, 2025 14:02 — with GitHub Actions Inactive
@denik denik requested a review from pietern September 4, 2025 14:08
@denik denik added this pull request to the merge queue Sep 4, 2025
Merged via the queue into main with commit 8b7f506 Sep 4, 2025
13 checks passed
@denik denik deleted the denik/increase-timeout branch September 4, 2025 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants