Add hidden "bundle debug refschema" command #3555
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remote-state
branch
from
f99310a to
f6dad89
Compare
denik
force-pushed
the
denik/bundle-refschema
branch
from
0048704 to
3cab680
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
approved these changes
Sep 8, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
The output highlights the ambiguity between the "settings" and "spec" duplication for jobs and pipelines, respectively. Let's discuss. Not blocking for this PR.
Please check the suggestion before merging.
cmd/bundle/bundle.go
Outdated
| cmd.AddCommand(deployment.NewDeploymentCommand()) | ||
| cmd.AddCommand(newOpenCommand()) | ||
| cmd.AddCommand(newPlanCommand()) | ||
| cmd.AddCommand(newRefSchemaCommand()) |
Contributor
There was a problem hiding this comment.
We can use the debug subcommand to host this, to group commands we'll keep hidden.
Contributor
Author
There was a problem hiding this comment.
Sure, we can move it there. In that case it does not need to be hidden.
denik
force-pushed
the
denik/bundle-refschema
branch
from
3cab680 to
6f52ca4
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
changed the title
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
github-merge-queue bot
pushed a commit
that referenced
this pull request
Sep 9, 2025
…pe (#3573) ## Changes Pure refactoring, no functional changes. ## Why Follow to #3531 (comment) We already use STATE to refer to this schema in #3555 Config is ambiguous, we have already bundle config (called input config in terranova). With this rename we have - input config -- what's in databricks.yml - state - what's persisted, what is sent to backend via create/update - remote state - what we get from backend via get requests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Requires #3531
Why
Track bundle schema changes. Unlike jsonschema, this includes not just input yaml but stored state and remote resource types. This will help us notice when something disappears or changes type in the state or remote, as this has potential of breaking existing deployments.
It is also in greppable format, could be useful for debugging complex $resources.jobs.foo.tasks[0].something.something else references.
Tests
I also added recording of "bundle debug" output under acceptance/bundle/debug.