direct: Add RemapState resource method #3586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
bc87791 to
3d288fc
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
375cd35 to
cdbd8f2
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
a8d9cf3 to
f6cc232
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
f6cc232 to
6fa9377
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
6fa9377 to
472d100
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
adef351 to
472d100
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
fd3df71 to
aaeeac9
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/remap-state
branch
from
5543af2 to
8afd69e
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Sep 15, 2025
pietern
reviewed
Sep 16, 2025
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
The struct copies are covered with the linter to check for completeness?
| return &input.JobSettings | ||
| } | ||
|
|
||
| func (*ResourceJob) RemapState(jobs *jobs.Job) *jobs.JobSettings { |
Contributor
There was a problem hiding this comment.
It could be worth adding type aliases for readability. We have 3 types that we're dealing with here:
- Config type:
resources.Job - State type:
jobs.JobSettings - Remote type:
jobs.Job
If we alias each of these to e.g. JobConfig, JobState, JobRemote, then it is unambiguous in which direction the remapping happens. It's not clear without context that this function maps from the remote type to the state type.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
New RemapState() method on resource that transform remote state to config type.
Why
To be used to detect remote drift.
Tests
Unit tests.