Skip to content

Remove terraform.Write/Interpolate calls from various commands #3804

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
denik merged 1 commit into from
Oct 23, 2025
Merged

Remove terraform.Write/Interpolate calls from various commands #3804

denik merged 1 commit into from
Oct 23, 2025

Conversation

@denik
Copy link
Contributor

@denik denik commented Oct 22, 2025

Changes

Remove terraform.Write/Interpolate calls from various commands

  • bundle generate dashboard
  • bundle open
  • pipelines open / run / stop / dry_run

Why

Follow up to #3803 and #3169

There used to be 'terraform show' call that needed it, but it's no longer used.

Tests

Existing tests.

@denik denik temporarily deployed to test-trigger-is October 22, 2025 15:06 — with GitHub Actions Inactive
@denik denik force-pushed the denik/remove-interpolate-from-summary branch from 59369d3 to 220f967 Compare October 22, 2025 15:19
@denik denik force-pushed the denik/remove0-terraform-interpolat branch from dadefcf to 617c812 Compare October 22, 2025 15:19
@denik denik temporarily deployed to test-trigger-is October 22, 2025 15:19 — with GitHub Actions Inactive
@eng-dev-ecosystem-bot
Copy link
Collaborator

eng-dev-ecosystem-bot commented Oct 22, 2025 •
edited
Loading

Run: 18741217766

Env 🔄​flaky 💚​RECOVERED 🙈​SKIP ✅​pass 🙈​skip
🔄​ aws linux 3 1 319 567
💚​ aws windows 1 1 322 566
💚​ aws-ucws linux 1 1 439 463
💚​ aws-ucws windows 1 1 440 462
💚​ azure linux 1 1 321 566
🔄​ azure windows 2 1 1 320 565
💚​ azure-ucws linux 1 1 437 462
💚​ azure-ucws windows 1 1 438 461
🔄​ gcp linux 4 1 1 316 568
🔄​ gcp windows 6 1 1 315 567
14 failing tests:
Test Name aws linux aws windows aws-ucws linux aws-ucws windows azure linux azure windows azure-ucws linux azure-ucws windows gcp linux gcp windows
TestAccept 🔄​f 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R 💚​R
TestAccept/bundle/resources/pipelines/allow-duplicate-names 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/resources/pipelines/allow-duplicate-names/DATABRICKS_BUNDLE_ENGINE=terraform 🔄​f ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/resources/pipelines/auto-approve ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
TestAccept/bundle/resources/pipelines/auto-approve/DATABRICKS_BUNDLE_ENGINE=terraform ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
TestAccept/bundle/resources/pipelines/lakeflow-pipeline ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
TestAccept/bundle/resources/pipelines/lakeflow-pipeline/DATABRICKS_BUNDLE_ENGINE=direct-exp ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
TestAccept/bundle/resources/pipelines/lakeflow-pipeline/DATABRICKS_BUNDLE_ENGINE=terraform ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f 🔄​f
TestAccept/bundle/run/app-with-job 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S 🙈​S
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct-exp/DLT=yes/NBOOK=no/PY=yes ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p ✅​p ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=direct-exp/DLT=yes/NBOOK=yes/PY=no ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p ✅​p 🔄​f ✅​p
TestAccept/bundle/templates/default-python/combinations/classic/DATABRICKS_BUNDLE_ENGINE=terraform/DLT=yes/NBOOK=no/PY=no ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f ✅​p
TestAccept/bundle/templates/default-python/integration_classic ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f
TestAccept/bundle/templates/default-python/integration_classic/DATABRICKS_BUNDLE_ENGINE=terraform/UV_PYTHON=3.9 ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p ✅​p 🔄​f

Base automatically changed from denik/remove-interpolate-from-summary to main October 23, 2025 07:40
@denik
Remove terraform.Write/Interpolate calls from various commands
91bd00f 
- bundle generate dashboard
- bundle open
- pipelines open / run / stop / dry_run
@denik denik force-pushed the denik/remove0-terraform-interpolat branch from 617c812 to 91bd00f Compare October 23, 2025 07:41
@denik denik temporarily deployed to test-trigger-is October 23, 2025 07:41 — with GitHub Actions Inactive
@denik denik enabled auto-merge October 23, 2025 10:51
@denik denik added this pull request to the merge queue Oct 23, 2025
Merged via the queue into main with commit b2c8c46 Oct 23, 2025
13 checks passed
@denik denik deleted the denik/remove0-terraform-interpolat branch October 23, 2025 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pietern pietern pietern approved these changes

@andrewnester andrewnester andrewnester approved these changes

@jefferycheng1 jefferycheng1 Awaiting requested review from jefferycheng1 jefferycheng1 is a code owner

@kanterov kanterov Awaiting requested review from kanterov kanterov is a code owner

@lennartkats-db lennartkats-db Awaiting requested review from lennartkats-db lennartkats-db is a code owner

@anton-107 anton-107 Awaiting requested review from anton-107 anton-107 is a code owner

@shreyas-goenka shreyas-goenka Awaiting requested review from shreyas-goenka shreyas-goenka is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@denik @eng-dev-ecosystem-bot @pietern @andrewnester