Add apps import command
#4293
Merged
Add apps import command
#4293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
changed the title
apps import command
Collaborator
|
Commit: 3eb9e77
24 interesting tests: 8 RECOVERED, 6 flaky, 5 KNOWN, 5 SKIP
Top 50 slowest tests (at least 2 minutes):
|
lennartkats-db
previously requested changes
Jan 16, 2026
fjakobs
force-pushed
the
apps/import-2
branch
from
aae9d50 to
a82e92a
Compare
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
had a problem deploying
to
test-trigger-is
GitHub Actions
Failure
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
cmd/workspace/apps/import.go
Outdated
| }, | ||
| } | ||
|
|
||
| cmd.Flags().StringVar(&appName, "app-name", "", "Name of the app to import (if not specified, lists all apps)") |
Contributor
There was a problem hiding this comment.
Suggested change
| cmd.Flags().StringVar(&appName, "app-name", "", "Name of the app to import (if not specified, lists all apps)") | |
| cmd.Flags().StringVar(&appName, "name", "", "Name of the app to import (if not specified, lists all apps)") |
I would change this to --name so its consistent with the rest of the commands
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
MarioCadenas
approved these changes
Jan 22, 2026
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Adds comprehensive unit tests for the apps import command focusing on edge cases: - YAML formatting (addBlankLinesBetweenTopLevelKeys) - App config inlining (inlineAppConfigFile) - Path detection for .bundle folders - Email parsing and comparison logic - Error handling for file operations and invalid YAML Refactored code to use existing convert.FromTyped instead of custom conversion logic. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Use platform-specific methods to deny file read access in test: - Windows: Use icacls to deny read permissions via ACLs - Unix: Use chmod to remove read permissions This fixes the TestInlineAppConfigFileErrors/unreadable_app.yml test that was failing on Windows because Unix-style file permissions don't work the same way on Windows systems. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Verify that the file is actually unreadable after running icacls. If the file is still readable, skip the test with a clear message. This handles cases where the icacls command runs successfully but doesn't actually deny read access (e.g., due to admin privileges or UAC settings). Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
fjakobs
force-pushed
the
apps/import-2
branch
from
88717dc to
7b6f251
Compare
fjakobs
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
fjakobs
dismissed
lennartkats-db’s stale review
aligned offline on slack. Using import is fine.
Collaborator
|
Commit: 472f05d
50 interesting tests: 20 FAIL, 12 flaky, 8 RECOVERED, 5 KNOWN, 5 SKIP
Top 50 slowest tests (at least 2 minutes):
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add
databricks apps importcommand.Import an app created in the workspace with a single command
This command combines:
The generated
databricks.ymlis minimal and optimized for single app bundles.Screen.Recording.2026-01-16.at.11.19.37.mov