Add --yaml flag to bundle generate alert command #4379
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add ConvertAlertToValueWithDefinition function to embed alert definition in YAML - Add --yaml flag to bundle generate alert command - When --yaml is used, alert definition is embedded directly in YAML config - When --yaml is not used, maintains existing behavior with separate .dbalert.json file - Add acceptance test for --yaml flag functionality Fixes databricks#4315 Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com>
KunalSachdev2005
requested review from
andrewnester,
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4315
Changes
ConvertAlertToValueWithDefinitionfunction to embed alert definition in YAML--yamlflag tobundle generate alertcommand--yamlis used, alert definition is embedded directly in YAML config--yamlis not used, maintains existing behavior with separate.dbalert.jsonfile--yamlflag functionalityWhy
This allows users to manage their entire alert configuration in a single YAML file instead of maintaining separate
.dbalert.jsonfiles. It makes version control simpler (one file to track), leads to easier code reviews (all changes are in one place), and it makes it more convenient for users who prefer YAML over JSON.Tests
acceptance/bundle/generate/alert_yaml/bundle generate alerttest still passes (I verified backward compatibility)Example Usage
Without
--yaml(existing behavior):Creates:
resources/alert.yml+src/alert.dbalert.jsonWith
--yaml(new feature):Creates:
resources/alert.yml(with embedded definition)