direct: Set default reason="custom" for OverrideChangeDesc#4383
Merged
Conversation
denik
changed the title
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
denik
force-pushed
the
denik/reason-overridefunc
branch
from
e221e39 to
c695596
Compare
pietern
reviewed
Jan 28, 2026
Contributor
pietern
left a comment
pietern
left a comment
There was a problem hiding this comment.
"... keep the reason ... " empty?
I don't understand how to interpret "override" as the reason. What does it mean?
| "changes": { | ||
| "etag": { | ||
| "action": "skip", | ||
| "reason": "override", |
Contributor
There was a problem hiding this comment.
What does override reason mean? It's not clear to me how to interpret this.
Contributor
Author
It's not always empty, check the test output. In one case original reason was "remote_already_set".
It means coming from OverrideChangeDesc() function. We can use another word. |
Collaborator
|
Commit: 547fddd
42 interesting tests: 20 FAIL, 10 KNOWN, 5 SKIP, 4 flaky, 3 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
denik
changed the title
pietern
approved these changes
Jan 28, 2026
Collaborator
|
Commit: 5c11b27
20 interesting tests: 9 KNOWN, 5 SKIP, 4 RECOVERED, 2 flaky
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
When OverrideChangeDesc function changes the action but not the reason, set the reason to "custom".
Why
It's easy to accidentally forget to update the reason in OverrideChangeDesc func (this is what happens for dashboards today).
Tests
Existing tests that record the plan.