Add new invariant test config job_with_task; expand testserver jobs with defaults#4479
Merged
Add new invariant test config job_with_task; expand testserver jobs with defaults#4479
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern and
shreyas-goenka
as code owners
Collaborator
|
Commit: 5d0961c
15 interesting tests: 7 KNOWN, 7 SKIP, 1 RECOVERED
Top 7 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 5d0961c
21 interesting tests: 7 KNOWN, 7 SKIP, 6 flaky, 1 RECOVERED
Top 14 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 5d0961c
21 interesting tests: 7 KNOWN, 7 SKIP, 6 flaky, 1 RECOVERED
Top 26 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 081e46d
60 interesting tests: 29 FAIL, 14 flaky, 7 KNOWN, 5 SKIP, 5 RECOVERED
Top 50 slowest tests (at least 2 minutes):
|
denik
force-pushed
the
denik/aws-attributes
branch
from
0e28df6 to
aab2e4b
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
approved these changes
Feb 10, 2026
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
force-pushed
the
denik/aws-attributes
branch
from
ba7f1c3 to
e33a8c7
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Shows things like aws_attributes in remote state, which are currently ignored due to server_side_default. However, once we add remove server_side_default we'd like those properties to be ignored as they are known to be set by backend.
The testserver now adds AWS-specific server-side defaults to job tasks with new_cluster configurations, matching the behavior of actual AWS cloud environments. This ensures local acceptance tests produce consistent output with cloud tests. Added defaults: - task.email_notifications: empty struct - task.run_if: ALL_SUCCESS - task.timeout_seconds: 0 - task.new_cluster.aws_attributes: availability=SPOT_WITH_FALLBACK, zone_id=us-east-1c - task.new_cluster.data_security_mode: SINGLE_USER - task.new_cluster.enable_elastic_disk: false Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
denik
force-pushed
the
denik/aws-attributes
branch
from
e33a8c7 to
081e46d
Compare
denik
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
added a commit
that referenced
this pull request
Feb 10, 2026
## Changes Add gron.py inspired by https://github.com/tomnomnom/gron ## Why Simpler grepping of json, simpler to write than jq. I need this for #4479 where terraform & direct payload starts to differ in update due to more defaults added to testserver & terraform persisting those in state while direct does not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Why
Those changes are currently skipped via server_side_default, once that is removed, this test will ensure that we have something else in place.