acc: add cleanup trap to postgres acceptance tests#4489
Merged
Conversation
Add cleanup function with trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks. Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
pietern
requested review from
andrewnester,
anton-107,
denik and
shreyas-goenka
as code owners
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 797f01c
15 interesting tests: 8 RECOVERED, 7 SKIP
Top 20 slowest tests (at least 2 minutes):
|
Contributor
Author
|
The tests that failed were fixed by #4483. |
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
approved these changes
Feb 11, 2026
pietern
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add cleanup trap to ensure postgres branches and endpoints are destroyed after tests complete, preventing resource leaks.
Test plan
Run affected acceptance tests:
go test ./acceptance -run TestAccept/bundle/resources/postgres_branches/without_branch_idgo test ./acceptance -run TestAccept/bundle/resources/postgres_endpoints/without_endpoint_id🤖 Generated with Claude Code