Skip to content

Fix Select title hidden by Filtering(true) in apps init prompts#4603

Open
jamesbroadhead wants to merge 3 commits intodatabricks:mainfrom
jamesbroadhead:improve-resource-prompt-description
Open

Fix Select title hidden by Filtering(true) in apps init prompts#4603
jamesbroadhead wants to merge 3 commits intodatabricks:mainfrom
jamesbroadhead:improve-resource-prompt-description

Conversation

@jamesbroadhead
Copy link

Summary

  • huh.Select.Filtering(true) immediately activates filter mode, which replaces the Title with a blank filter text input in titleView() — so the user never saw what resource they were selecting (e.g., "Select SQL Warehouse")
  • Remove Filtering(true) so the Title renders on initial display. Users can still press / to activate filtering (bound by default in huh's keymap)
  • Update the description hint from "type to filter" to "press / to filter" to match the new behavior

Affects both promptFromListWithLabel (all resource pickers during apps init) and PromptForAppSelection.

Test plan

  • Run databricks apps init interactively, select a feature, and verify the resource picker title (e.g., "Select SQL Warehouse") is now visible
  • Verify pressing / activates filtering and typing filters the list
  • Verify pressing Esc exits filter mode and restores the title

🤖 Generated with Claude Code

huh's Select.Filtering(true) immediately activates filter mode, which
replaces the Title with a blank filter text input in titleView().
This meant the user never saw what resource they were being asked to
select (e.g., "Select SQL Warehouse").

Remove Filtering(true) so the Title renders. Users can still press /
to activate filtering (bound by default in huh's keymap). Update the
description hint from "type to filter" to "press / to filter".

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@jamesbroadhead jamesbroadhead requested a review from a team as a code owner February 25, 2026 22:01
Test that:
- Title is visible in the initial render without Filtering(true)
- Filtering(true) replaces the Title with a blank filter input (the bug)
- Pressing '/' activates filtering and correctly filters options
- Help text includes the filter hint

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
@github-actions
Copy link

github-actions bot commented Mar 3, 2026

An authorized user can trigger integration tests manually by following the instructions below:

Trigger:
go/deco-tests-run/cli

Inputs:

  • PR number: 4603
  • Commit SHA: bd34b1e51b83d5297d9bb72c049e1fbeb02ae087

Checks will be approved automatically on success.

Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Sorry, missed this PR last week - but also noticed the issue today: c8c3c0d 😄

pkosiec added a commit that referenced this pull request Mar 5, 2026
Revert the description hint and Filtering(true/false) changes in
promptFromListWithLabel and PromptForAppSelection, as these are
addressed properly in PR #4603.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
pkosiec added a commit that referenced this pull request Mar 5, 2026
Revert the description hint and Filtering(true/false) changes in
promptFromListWithLabel and PromptForAppSelection, as these are
addressed properly in PR #4603.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants