Validate that either source_code_path or git_source is set for apps#4632
Merged
andrewnester merged 3 commits intomainfrom Mar 3, 2026
Merged
Validate that either source_code_path or git_source is set for apps#4632andrewnester merged 3 commits intomainfrom
andrewnester merged 3 commits intomainfrom
Conversation
andrewnester
requested review from
anton-107,
denik,
pietern and
shreyas-goenka
as code owners
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 27b2026
20 interesting tests: 7 KNOWN, 7 SKIP, 5 BUG, 1 RECOVERED
Top 20 slowest tests (at least 2 minutes):
|
denik
approved these changes
Mar 3, 2026
Collaborator
|
Commit: 10d976b
60 interesting tests: 16 KNOWN, 15 flaky, 13 FAIL, 8 RECOVERED, 7 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
mihaimitrea-db
pushed a commit
that referenced
this pull request
Mar 5, 2026
…4632) Validate that either source_code_path or git_source is set for apps Previously, we always required setting the `source_code_path` field. Now, with the introduction of the git_source field, this isn't required anymore, and one of the two fields can only be set Added an acceptance test <!-- If your PR needs to be included in the release notes for next release, add a separate entry in NEXT_CHANGELOG.md as part of your PR. -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Validate that either source_code_path or git_source is set for apps
Why
Previously, we always required setting the
source_code_pathfield. Now, with the introduction of the git_source field, this isn't required anymore, and one of the two fields can only be setTests
Added an acceptance test