Simulate app service principal and job permissions in test server#4644
Merged
Simulate app service principal and job permissions in test server#4644
Conversation
The apps platform assigns a service principal to each app and grants that principal permissions on referenced resources. This change makes the test server mimic that behavior so we can write acceptance tests that exercise the permission lifecycle across multiple deploys. The acceptance test is restricted to the terraform engine. The direct engine fails during planning because PermissionsState doesn't support slice indexing into ACL entries, causing an error like: cannot set (*dresources.PermissionsState).[0].service_principal_name to string: failed to navigate to parent [0]: cannot index struct The permissions dedup logic in SetPermissions is refactored into a shared upsertACL helper to avoid duplicating the find-or-replace pattern. Relates to #4309 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
pietern
requested review from
andrewnester,
anton-107,
denik,
shreyas-goenka and
simonfaltum
as code owners
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
denik
reviewed
Mar 3, 2026
Collaborator
|
Commit: af2a258
26 interesting tests: 8 FAIL, 7 KNOWN, 7 SKIP, 2 BUG, 2 flaky
Top 25 slowest tests (at least 2 minutes):
|
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
denik
approved these changes
Mar 5, 2026
Collaborator
|
Commit: 08123e4
41 interesting tests: 20 RECOVERED, 13 FAIL, 6 flaky, 1 KNOWN, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SetPermissionsdedup logic into a sharedupsertACLhelperThe acceptance test is restricted to the terraform engine. The direct engine fails during planning:
Test plan
Relates to #4309
🤖 Generated with Claude Code