make generate: skip fetch if commit already exists locally#4668
Merged
Conversation
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
denik
force-pushed
the
denik/speedup-makefile
branch
from
ef824bf to
cffc4d9
Compare
| generate: | ||
| @echo "Checking out universe at SHA: $$(cat .codegen/_openapi_sha)" | ||
| cd $(UNIVERSE_DIR) && git fetch origin master && git checkout $$(cat $(PWD)/.codegen/_openapi_sha) | ||
| cd $(UNIVERSE_DIR) && git cat-file -e $$(cat $(PWD)/.codegen/_openapi_sha) 2>/dev/null || git fetch --filter=blob:none origin master && git checkout $$(cat $(PWD)/.codegen/_openapi_sha) |
Contributor
There was a problem hiding this comment.
nit, refactor $$(cat $(PWD)/.codegen/_openapi_sha) as a variable.
shreyas-goenka
approved these changes
Mar 5, 2026
simonfaltum
approved these changes
Mar 5, 2026
Collaborator
|
Commit: cffc4d9
26 interesting tests: 8 FAIL, 7 SKIP, 6 RECOVERED, 3 flaky, 1 KNOWN, 1 BUG
Top 21 slowest tests (at least 2 minutes):
|
Collaborator
|
Commit: 7c46b5d
49 interesting tests: 22 RECOVERED, 13 FAIL, 8 MISS, 2 KNOWN, 2 flaky, 1 BUG, 1 SKIP
Top 50 slowest tests (at least 2 minutes):
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Reduce time "make generate" takes to fetch the commit from 70s to 0.5s.
Tests
Manually running "make generate".