Add elapsed time display to spinners#4697
Open
anton-107 wants to merge 1 commit intossh-connect-ux-spinnersfrom
Open
Add elapsed time display to spinners#4697anton-107 wants to merge 1 commit intossh-connect-ux-spinnersfrom
anton-107 wants to merge 1 commit intossh-connect-ux-spinnersfrom
Conversation
anton-107
requested review from
andrewnester,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
force-pushed
the
ssh-connect-ux-spinners
branch
from
9b4dc5d to
f5a32d5
Compare
Add TrackElapsedTime() method to the spinner that shows a running MM:SS stopwatch next to the spinner message. The time updates on every spinner tick (200ms). Enable it for all SSH connect spinners so users can see how long each step has been running. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
anton-107
force-pushed
the
ssh-connect-elapsed-time
branch
from
284aa8e to
c8eceee
Compare
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: c8eceee
16 interesting tests: 7 SKIP, 6 RECOVERED, 3 flaky
Top 22 slowest tests (at least 2 minutes):
|
7 tasks
pietern
reviewed
Mar 12, 2026
| return m.spinner.View() | ||
| if !m.startTime.IsZero() { | ||
| elapsed := time.Since(m.startTime) | ||
| result += fmt.Sprintf(" %02d:%02d", int(elapsed.Minutes()), int(elapsed.Seconds())%60) |
Contributor
There was a problem hiding this comment.
What happens if there is no suffix yet?
| spinner bubblespinner.Model | ||
| suffix string | ||
| quitting bool | ||
| startTime time.Time // non-zero when elapsed time display is enabled |
Contributor
There was a problem hiding this comment.
I recommend composing this as a "time spinner" that wraps this spinner and adds the time when View() is called. Then construct it with NewTimeSpinner.
Contributor
There was a problem hiding this comment.
This suggestion is prob overkill.
Re: the feature, I think doing prefixing instead of suffixing makes more sense because it won't jump around as updates happen. Second, the time can be initialized at construction time instead of a separate method, and then the time prefix as an option to the spinner at construction time.
simonfaltum
previously approved these changes
Mar 12, 2026
Member
simonfaltum
left a comment
simonfaltum
left a comment
There was a problem hiding this comment.
[Agent Swarm Review] Verdict: Approved
- 0 Critical
- 0 Major
- 0 Gap
- 1 Nit
- 0 Suggestion
Clean addition of elapsed time tracking to spinners. The TrackElapsedTime() method is well-integrated into the Bubble Tea model. Minor note: the MM:SS format doesn't handle hours, but SSH connect operations shouldn't take that long.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TrackElapsedTime()method to the spinner that shows a runningMM:SSstopwatch next to the spinner messageExample output:
⣾ Starting SSH server... (task: PENDING) 00:15Stacked on #4694
Test plan
databricks ssh connect --cluster <id>and verify elapsed time appears and ticks next to each spinnerTrackElapsedTime()) are unaffected🤖 Generated with Claude Code