Remove deprecated channel-based spinner API#4721
Merged
Conversation
Migrate remaining SCIM command callers (groups, users, service-principals) and repos overrides from the old channel-based cmdio.Spinner to the struct-based cmdio.NewSpinner API. Remove the old Spinner function, its backward-compatibility test, and the associated lint rule. Co-authored-by: Isaac
pietern
requested review from
andrewnester,
anton-107,
denik,
shreyas-goenka and
simonfaltum
as code owners
pietern
changed the title
Collaborator
|
Commit: 67a77bf
18 interesting tests: 9 SKIP, 7 KNOWN, 2 flaky
Top 21 slowest tests (at least 2 minutes):
|
denik
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmdio.Spinnerto struct-basedcmdio.NewSpinnerSpinnerfunction, backward-compat test, and lint ruleFollows #4720 (template regeneration), #4351, and #4377.
Test plan
go build ./...go test ./libs/cmdio/