Use per-target .PHONY declarations instead of combined list#4753
Merged
Conversation
Replaces the two combined .PHONY lines with individual `.PHONY: <target>` declarations placed immediately before each target definition. Also fixes bugs in the previous .PHONY declarations: - Missing (targets that existed but were not declared .PHONY): slowest, build-vm, dbr-integration, dbr-test, generate, test-exp-aitools, test-exp-ssh, test-pipelines, bench1k, bench100, bench10, bench1k_summary, bench100_summary, bench10_summary - Extra (declared .PHONY but target does not exist): acc-cover Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
denik
requested review from
andrewnester,
anton-107,
pietern,
shreyas-goenka and
simonfaltum
as code owners
Collaborator
|
Commit: 21b9169
20 interesting tests: 9 SKIP, 7 KNOWN, 4 flaky
Top 21 slowest tests (at least 2 minutes):
|
shreyas-goenka
approved these changes
Mar 16, 2026
rauchy
pushed a commit
that referenced
this pull request
Mar 17, 2026
## Summary - Replaces the two combined `.PHONY` lines with individual `.PHONY: <target>` declarations placed immediately before each target definition, making it easier to see at a glance which targets are phony. - Fixes bugs in the previous `.PHONY` declarations: - **Missing** (targets that existed but were not declared `.PHONY`): `slowest`, `build-vm`, `dbr-integration`, `dbr-test`, `generate`, `test-exp-aitools`, `test-exp-ssh`, `test-pipelines`, `bench1k`, `bench100`, `bench10`, `bench1k_summary`, `bench100_summary`, `bench10_summary` - **Extra** (declared `.PHONY` but target does not exist): `acc-cover` ## Test plan - [ ] No functional changes; verify `make build` and `make test` still work as expected. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-authored-by: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
.PHONYlines with individual.PHONY: <target>declarations placed immediately before each target definition, making it easier to see at a glance which targets are phony..PHONYdeclarations:.PHONY):slowest,build-vm,dbr-integration,dbr-test,generate,test-exp-aitools,test-exp-ssh,test-pipelines,bench1k,bench100,bench10,bench1k_summary,bench100_summary,bench10_summary.PHONYbut target does not exist):acc-coverTest plan
make buildandmake teststill work as expected.🤖 Generated with Claude Code