Conversation
The driver proxy rewrites URLs with double slashes (e.g. //metadata), which causes the default mux to issue a redirect loop. Use path.Clean to normalize request paths before routing. Co-authored-by: Isaac
anton-107
requested review from
andrewnester,
denik,
pietern,
shreyas-goenka and
simonfaltum
as code owners
anton-107
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
anton-107
changed the title
Collaborator
|
Commit: 06e62ca
18 interesting tests: 9 SKIP, 6 RECOVERED, 3 flaky
Top 20 slowest tests (at least 2 minutes):
|
ilia-db
approved these changes
Mar 16, 2026
rauchy
pushed a commit
that referenced
this pull request
Mar 17, 2026
…rom driver proxy (#4760) ## Summary - The driver proxy rewrites URLs with double slashes (e.g. `//metadata`), which causes Go's default mux to issue a 301 redirect to `/metadata/`, resulting in an infinite redirect loop. - Adds a `path.Clean` normalization step in the HTTP handler to clean up paths before routing. ## Test plan - [x] Deploy to a cluster behind driver proxy and verify `/metadata` responds with 200 - [x] Verify SSH connections still work through the proxy This pull request was AI-assisted by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
//metadata), which causes Go's default mux to issue a 301 redirect to/metadata/, resulting in an infinite redirect loop.path.Cleannormalization step in the HTTP handler to clean up paths before routing.Test plan
/metadataresponds with 200This pull request was AI-assisted by Isaac.