Skip to content

Inline indirect gopkg.in/yaml.v3 dependency#4937

Merged
pietern merged 2 commits into
mainfrom
inline-indirect-yaml-dep
Apr 13, 2026
Merged

Inline indirect gopkg.in/yaml.v3 dependency#4937
pietern merged 2 commits into
mainfrom
inline-indirect-yaml-dep

Conversation

@pietern
Copy link
Copy Markdown
Contributor

@pietern pietern commented Apr 13, 2026

Summary

Test plan

  • go mod tidy produces no diff

This pull request was AI-assisted by Isaac.

PR #4353 migrated direct imports to go.yaml.in/yaml/v3. PR #4400
added palantir/pkg/yamlpatch a week later, reintroducing
gopkg.in/yaml.v3 as a standalone indirect require line. Move it
into the grouped indirect block via go mod tidy.

Co-authored-by: Isaac
@pietern pietern requested a review from simonfaltum April 13, 2026 10:21
@pietern pietern enabled auto-merge April 13, 2026 10:22
@pietern pietern disabled auto-merge April 13, 2026 10:22
@pietern pietern enabled auto-merge April 13, 2026 11:21
@pietern pietern added this pull request to the merge queue Apr 13, 2026
Merged via the queue into main with commit fde66e1 Apr 13, 2026
27 checks passed
@pietern pietern deleted the inline-indirect-yaml-dep branch April 13, 2026 12:03
denik pushed a commit that referenced this pull request May 20, 2026
## Summary
- Move `gopkg.in/yaml.v3` from a standalone indirect `require` line into
the grouped indirect block via `go mod tidy`
- #4353 migrated direct imports to `go.yaml.in/yaml/v3` and moved
`gopkg.in/yaml.v3` into the grouped indirect block
- #4289 added a direct dependency on `gopkg.in/yaml.v3` (via
`palantir/pkg/yamlpatch`), pulling it back out as a standalone `require`
line
- #4400 marked it as `// indirect` but left it as a standalone line

## Test plan
- [x] `go mod tidy` produces no diff

This pull request was AI-assisted by Isaac.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants