Conversation
All usage was `maps.Keys`, `maps.Values`, `maps.Clone`, and `maps.Copy` from the `golang.org/x/exp/maps` package. These have been available in the Go standard library since: - `maps.Clone` and `maps.Copy`: Go 1.21 - `maps.Keys` and `maps.Values`: Go 1.23 (as iterator-returning functions) The stdlib `maps.Keys`/`maps.Values` return `iter.Seq` instead of a slice, so call sites are wrapped with `slices.Collect` where a slice is needed. Call sites already using `slices.Sorted(maps.Keys(...))` work as-is since `slices.Sorted` accepts an iterator. The module remains as an indirect dependency through databricks-sdk-go. Co-authored-by: Isaac
Co-authored-by: Isaac
denik
approved these changes
Apr 13, 2026
denik
pushed a commit
that referenced
this pull request
May 20, 2026
## Summary - Replace all `golang.org/x/exp/maps` usage with stdlib equivalents (`maps` and `slices` packages) - `maps.Clone`/`maps.Copy` are drop-in replacements (Go 1.21+) - `maps.Keys`/`maps.Values` return iterators in stdlib (Go 1.23+), so slice-consuming call sites are wrapped with `slices.Collect` - Remove `golang.org/x/exp` from NOTICE file; it remains as an indirect dependency through databricks-sdk-go This pull request was AI-assisted by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
golang.org/x/exp/mapsusage with stdlib equivalents (mapsandslicespackages)maps.Clone/maps.Copyare drop-in replacements (Go 1.21+)maps.Keys/maps.Valuesreturn iterators in stdlib (Go 1.23+), so slice-consuming call sites are wrapped withslices.Collectgolang.org/x/expfrom NOTICE file; it remains as an indirect dependency through databricks-sdk-goThis pull request was AI-assisted by Isaac.