Disable @-mentions in approval workflow comments#4965
Merged
simonfaltum merged 2 commits intomainfrom Apr 14, 2026
Merged
Conversation
Reviewer suggestions are useful but the @-mentions generate too many notifications. This changes the workflow to show plain usernames instead, so the comment still indicates who should review without pinging them. Co-authored-by: Isaac
denik
approved these changes
Apr 14, 2026
parthban-db
approved these changes
Apr 14, 2026
Instead of removing the @ prefix entirely, wrap mentions in backticks so they render as inline code on GitHub. This keeps the familiar @username format visible but prevents notification spam. Co-authored-by: Isaac
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The approval workflow comments currently @-mention everyone it suggests as a reviewer. This generates a lot of notification noise, especially on PRs that touch multiple ownership areas. The comments are useful for showing who should review, but the pings are disruptive.
Changes
Before: approval comments used
@usernamefor all suggested reviewers, eligible owners, and maintainers, triggering GitHub notifications for each.Now: all mentions are wrapped in backticks (
`@username`), so they render as inline code on GitHub. This preserves the familiar@prefix for readability but prevents GitHub from treating them as mentions that trigger notifications.All hardcoded
@mentions in the comment templates are now routed through a singlefmtLoginhelper controlled by the existingMENTION_REVIEWERSflag.Example comment (cross-domain PR)
Test plan