Remove no-op promptui.SearchPrompt assignment in warehouse picker#5168
Merged
Conversation
The line `promptui.SearchPrompt = "Search: "` in `SelectWarehouse` assigns the package-level global to its own default value (see `promptui/select.go`: `var SearchPrompt = "Search: "`), so it has no effect. It was introduced in #4170 (the only write to this global in the repo) alongside the warehouse picker added in #956. Drop the line and the now-unused promptui import. Co-authored-by: Isaac
pietern
changed the title
promptui.SearchPrompt assignment in warehouse picker
andrewnester
approved these changes
May 4, 2026
denik
pushed a commit
that referenced
this pull request
May 20, 2026
…5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in #4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in #956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.
TanishqDatabricks
pushed a commit
to TanishqDatabricks/cli
that referenced
this pull request
May 22, 2026
…atabricks#5168) ## Summary `SelectWarehouse` in `libs/databrickscfg/cfgpickers/warehouses.go` contains: ```go promptui.SearchPrompt = "Search: " ``` This assigns the package-level global to its own default. promptui declares it [here](https://github.com/manifoldco/promptui/blob/v0.9.0/select.go#L184) as `var SearchPrompt = "Search: "` — byte-identical to what we set. The line is the only write to `promptui.SearchPrompt` in the repo. It was introduced in databricks#4170 alongside the template-init warehouse picker. The original warehouse picker (`AskForWarehouse`, added in databricks#956) never had it, which suggests it's copy-paste residue rather than a deliberate override. ## Test plan - [x] `go build ./libs/databrickscfg/cfgpickers/` - [x] No behavior change expected — value matches promptui's default This pull request and its description were written by Isaac.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SelectWarehouseinlibs/databrickscfg/cfgpickers/warehouses.gocontains:This assigns the package-level global to its own default. promptui declares it here as
var SearchPrompt = "Search: "— byte-identical to what we set. The line is the only write topromptui.SearchPromptin the repo.It was introduced in #4170 alongside the template-init warehouse picker. The original warehouse picker (
AskForWarehouse, added in #956) never had it, which suggests it's copy-paste residue rather than a deliberate override.Test plan
go build ./libs/databrickscfg/cfgpickers/This pull request and its description were written by Isaac.