fix: convert duplicate YAML merge key panic to diagnostic error#5188
Merged
fix: convert duplicate YAML merge key panic to diagnostic error#5188
Conversation
Co-authored-by: Isaac
Replacing the panic with a LocationError that carries the source location, then converting it to a diagnostic in LoadFromBytes so the output shows the file/line/column and a clear explanation of what is not allowed and how to fix it. Co-authored-by: Isaac
Co-authored-by: Isaac
Co-authored-by: Isaac
janniklasrose
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Better error for #5182