test: cover nil target entries in bundle debug list-targets#5206
Open
pavloKozlov wants to merge 1 commit intomainfrom
Open
test: cover nil target entries in bundle debug list-targets#5206pavloKozlov wants to merge 1 commit intomainfrom
pavloKozlov wants to merge 1 commit intomainfrom
Conversation
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
force-pushed
the
test/list-targets-nil-check
branch
from
30b5c1f to
58c6da6
Compare
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
2 tasks
janniklasrose
approved these changes
May 7, 2026
Contributor
janniklasrose
left a comment
janniklasrose
left a comment
There was a problem hiding this comment.
thanks for the follow-up! unlucky the initial acceptance test already had {} but that didn't cover it
pavloKozlov
force-pushed
the
test/list-targets-nil-check
branch
from
58c6da6 to
08720c6
Compare
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
force-pushed
the
test/list-targets-nil-check
branch
from
08720c6 to
e5105be
Compare
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
denik
approved these changes
May 8, 2026
Replaces "staging: {}" with "staging:" in the existing acceptance test.
A null-bodied target follows the YAML→typed code path that produced the
nil *config.Target panic; with the guard in collectTargets the command
now lists the target by name instead of crashing.
pavloKozlov
force-pushed
the
test/list-targets-nil-check
branch
from
e5105be to
e8e7b52
Compare
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pavloKozlov
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectTargetsthat exercises the nil-entry path so the regression is locked in.*config.Targetentry through the loader pipeline (staging:,staging: null,staging: ~,staging: {}all yield non-nil entries). Direct unit coverage is the practical guard.Test plan
go test ./cmd/bundle/debug -run TestCollectTargetsHandlesNilEntriespasses.collectTargetsmakes the test fail with a nil pointer dereference.