cmdio: drop AskSelect, migrate caller to RunSelect#5219
Merged
Conversation
AskSelect was the only function in libs/cmdio/compat.go that mixed template-specific concerns (multi-line label handling) with cmdio. Its single caller in libs/template/config.go now calls cmdio.RunSelect directly and handles the prefix lines locally, shrinking cmdio's public surface by one. Added HideHelp to cmdio.SelectOptions so the template prompt keeps the hidden-help behavior that AskSelect previously hardcoded. Co-authored-by: Isaac
pietern
added a commit
that referenced
this pull request
May 8, 2026
cmdio.AskSelect is being removed in #5219 (its only caller migrated to RunSelect with the new HideHelp option), so this scenario would no longer compile against main once that lands. Co-authored-by: Isaac
simonfaltum
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cmdio.AskSelectwas the only function inlibs/cmdio/compat.gothat mixed template-specific concerns (multi-line label handling) with cmdio. Its single caller inlibs/template/config.gonow callscmdio.RunSelectdirectly and handles the prefix lines locally, shrinkingcmdio's public surface by one.HideHelptocmdio.SelectOptionsso the template prompt keeps the hidden-help behavior thatAskSelectpreviously hardcoded.Test plan
databricks bundle init default-pythonand confirm the enum prompts render their multi-line description and selection list as before.