Mark auto-generated files for GitHub linguist#5269
Merged
Conversation
Extends linguist-generated coverage beyond the genkit CLI stubs in cmd/account and cmd/workspace to include direct engine YAML, schema artifacts, mocks, pydabs codegen, acceptance test golden outputs, and the genkit-managed tagging workflow. Entries land in .gitattributes.manual so they survive `./task generate-genkit`, which overwrites .gitattributes and then prepends the manual file. Co-authored-by: Isaac
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
pietern
reviewed
May 19, 2026
|
|
||
| # Acceptance test golden outputs (./task test-update, ./task test-update-templates) | ||
| acceptance/**/out* linguist-generated=true | ||
| acceptance/**/output/** linguist-generated=true |
Contributor
There was a problem hiding this comment.
I like seeing these on all PRs because it forces you to acknowledge any side effects of the change.
Sometimes the unexpected behavior is captured only inside the output files.
| python/databricks/bundles/volumes/** linguist-generated=true | ||
|
|
||
| # Acceptance test golden outputs (./task test-update, ./task test-update-templates) | ||
| acceptance/**/out* linguist-generated=true |
Contributor
There was a problem hiding this comment.
I think all the output of the acceptance test is important to see explicitly as it helps to detect the changes in behaviour
| internal/mocks/**/*.go linguist-generated=true | ||
|
|
||
| # Genkit-generated tagging artifacts (./task generate-genkit) | ||
| internal/genkit/tagging.py linguist-generated=true |
Contributor
There was a problem hiding this comment.
I'd maybe keep this unhidden because if there's something changes here it can affect the release process
Follow the existing pattern of local .gitattributes files (bundle/schema/,
bundle/internal/tf/, bundle/internal/validation/generated/, acceptance/,
integration/) instead of one large block in the root .gitattributes.
Also drop entries the reviewers asked to leave visible:
- internal/genkit/tagging.py{,.lock} and .github/workflows/tagging.yml
(release-relevant)
- acceptance/**/out* and acceptance/**/output/** (acceptance output changes
are signal in code review)
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
janniklasrose
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
andrewnester
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Extend
linguist-generated=truecoverage so generated files don't pollute language stats or show up as hand-written code in review. Follows the existing convention of one local.gitattributesper generated folder (alongsidebundle/schema/,bundle/internal/tf/,bundle/internal/validation/generated/,acceptance/,integration/).New / updated local files:
.gitattributeslocation./task generate-directbundle/direct/dresources/*.generated.yml./task generate-schema-docsbundle/schema/(extended)jsonschema_for_docs.json./task generate-schemabundle/internal/schema/annotations_openapi.yml./task generate-docsbundle/docsgen/output/*.mdmockeryinternal/mocks/*.go./task pydabs-codegenpython/databricks/bundles/{catalogs,jobs,pipelines,schemas,volumes}/**Excluded by request from review:
internal/genkit/tagging.py{,.lock}and.github/workflows/tagging.yml— kept visible because changes there can affect the release process (@andrewnester).acceptance/**/out*andacceptance/**/output/**— kept visible because acceptance-output diffs are how reviewers detect behavior changes (@pietern, @andrewnester).Why
bundle/direct/dresources/apitypes.generated.yml(andresources.generated.yml) were showing up as human-authored code on GitHub. The genkit-managed section of the root.gitattributesonly coverscmd/account/**andcmd/workspace/**, so the rest of the auto-generated tree was unmarked. This brings linguist's view in line with.agent/rules/auto-generated-files.md.Tests
Verified each pattern with
git check-attr linguist-generated <path>:true.unspecified:bundle/direct/dresources/apitypes.yml,bundle/internal/schema/annotations.yml,bundle/internal/schema/annotations_openapi_overrides.yml,bundle/docsgen/{main.go,README.md},bundle/schema/schema.go,internal/mocks/README.md,python/databricks/bundles/{__init__.py,build.py,core/**}..gitattributesfiles (TF schema, validation generated,bundle/schema/jsonschema.json, acceptanceout.test.toml) still resolve correctly../task wspasses.This PR was written by Claude Code.