lakebox: add start command, tab completion, fail-fast on unknown sandbox#5308
Open
akshaysingla-db wants to merge 1 commit into
Open
Conversation
Three small additions that close gaps surfaced testing the gateway-host PR end-to-end. 1. `databricks lakebox start <id>` — wraps the existing StartSandbox RPC. Symmetric to `stop`. Useful for pre-warming a sandbox before connecting (the gateway also auto-starts on ssh, so this is mostly for scripting). 2. Tab completion for sandbox IDs on every command that takes one (ssh / status / stop / start / delete / config / set-default) and key hashes on `ssh-key delete`. Best-effort: completion silently produces no suggestions when the API call fails so the shell stays usable. Standard Cobra ValidArgsFunction pattern, surfaced via `databricks completion bash|zsh|fish` like every other Cobra CLI. 3. `databricks lakebox ssh <unknown-id>` now fails with `no lakebox named "..." — `databricks lakebox list` shows available IDs` instead of falling through to ssh and surfacing `Permission denied (publickey)` from the gateway. Implemented by making the existing pre-ssh `api.get` (added in databricks#5292 for gateway discovery) treat `apierr.ErrNotFound` as fatal. Non-NotFound errors still fall through so transient API hiccups don't block a connection the gateway can still route. Co-authored-by: Isaac
Contributor
Waiting for approvalBased on git history, these people are best suited to review:
Eligible reviewers: Suggestions based on git history. See OWNERS for ownership rules. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small additions that close gaps surfaced testing the gateway-host PR end-to-end.
databricks lakebox start <id>— wraps the existing StartSandbox RPC. Symmetric tostop. Useful for pre-warming a sandbox before connecting (the gateway also auto-starts on ssh, so this is mostly for scripting).Tab completion for sandbox IDs on every command that takes one (ssh / status / stop / start / delete / config / set-default) and key hashes on
ssh-key delete. Best-effort: completion silently produces no suggestions when the API call fails so the shell stays usable. Standard Cobra ValidArgsFunction pattern, surfaced viadatabricks completion bash|zsh|fishlike every other Cobra CLI.databricks lakebox ssh <unknown-id>now fails withno lakebox named "..." —databricks lakebox listshows available IDsinstead of falling through to ssh and surfacingPermission denied (publickey)from the gateway. Implemented by making the existing pre-sshapi.get(added in lakebox: read SSH gateway host from Sandbox response, cache per profile #5292 for gateway discovery) treatapierr.ErrNotFoundas fatal. Non-NotFound errors still fall through so transient API hiccups don't block a connection the gateway can still route.Co-authored-by: Isaac
Changes
Why
Tests