resources: centralise InitializeURL through libs/workspaceurls by janniklasrose · Pull Request #5346 · databricks/cli

janniklasrose · 2026-05-27T12:50:53Z

Changes

Move the 11 inline resource URL builders (catalogs, schemas, volumes, database_catalogs, database_instances, postgres_catalogs, postgres_synced_tables, quality_monitors, synced_database_tables, vector_search_endpoints, vector_search_indexes) onto workspaceurls.ResourceURL, joining the ones (jobs, pipelines, apps, ...) that already used it. Each resource's InitializeURL is now a one-liner; resource-specific guards (ModifiedStatus on DatabaseInstance, 3-part name check on PostgresSyncedTable and VectorSearchIndex) stay in the resource.

The new patterns and dotSeparatedResources flags live in libs/workspaceurls/urls.go, which also drives the experimental open command — its supported-type list grows from 13 to 24. Acceptance snapshot for experimental/open regenerated to match.

One behaviour delta on postgres_synced_tables / vector_search_indexes pre-deploy: the previous strings.Cut-twice logic produced a malformed URL like [DATABRICKS_URL]/explore/data/$%7Bresources/postgres_catalogs/my_catalog.catalog_id%7D.public.trips_synced when the name still contained an unresolved ${resources.X.Y} reference. The new strict 3-part check leaves the URL empty, so summary now renders (not deployed) — matching how database_instances (and others) already report pre-deploy state.

Why

Two parallel implementations of the same idea drift over time. Putting every resource's URL on the same lookup means future additions only touch one map, and tests like TestBundleResourcePluralNamesResolveInWorkspaceURLs (extended here) can fail loudly when a bundle plural name or pattern key drifts.

Tests

go test ./libs/workspaceurls/ ./bundle/config/ ./bundle/config/resources/ ./bundle/config/mutator/ ./cmd/experimental/ — green
./task lint — 0 issues
./task fmt, ./task checks — clean
Acceptance: TestAccept/bundle/resources/..., TestAccept/bundle/summary/..., TestAccept/experimental/open all green. Regenerated:
- acceptance/experimental/open/output.txt (expanded supported-type list)
- acceptance/bundle/resources/postgres_synced_tables/basic/output.txt (URL → (not deployed) pre-deploy)

This pull request was written by Claude Code.

eng-dev-ecosystem-bot · 2026-05-27T13:34:20Z

Commit: aadde2a

Run: 26515771331

Move the 11 inline resource URL builders (catalogs, schemas, volumes, database_catalogs, database_instances, postgres_catalogs, postgres_synced_tables, quality_monitors, synced_database_tables, vector_search_endpoints, vector_search_indexes) onto workspaceurls.ResourceURL, joining the ones (jobs, pipelines, apps, ...) that already used it. Each resource's InitializeURL is now a one-liner; resource-specific guards (ModifiedStatus on DatabaseInstance, 3-part name check on PostgresSyncedTable and VectorSearchIndex) stay in the resource. The new patterns and dotSeparatedResources flags live in libs/workspaceurls/urls.go, which also drives the experimental open command -- its supported-type list grows from 13 to 24. PostgresSyncedTable's and VectorSearchIndex's previous strings.Cut-twice logic produced a malformed URL when the name still contained an unresolved ${resources.X.Y} reference. The new strict 3-part check leaves the URL empty, so summary now renders "(not deployed)" -- matching the rest of the codebase (e.g. database_instances). Co-authored-by: Isaac

Co-authored-by: Isaac

denik · 2026-05-27T14:05:27Z

  Postgres projects:
    my_project:
      Name: Test Project for Synced Table
      URL:  (not deployed)


This still says "(not deployed)", is it intentional? @pietern

See also PR summary. The previous value was wrong (you can see the reference still in the URL), and since the backend-minted ID is required to render the URL it shows (not deployed) until it is

oops, nvm I thought you were referring to the actual edit above. But you mean my_project not getting updated post-deployment!

Related to https://github.com/databricks/cli/pull/5346/changes#r3311349591 I guess, since the resource currently opts out of URLs.

denik · 2026-05-27T14:10:07Z

@@ -123,15 +123,26 @@ func TestBundleResourcePluralNamesResolveInWorkspaceURLs(t *testing.T) {
 	withURLs := []string{


a) It seems easier to include missing ones?

b) Should there be missing ones? I see these are missing, is that intentional?

external_locations cc @andrewnester

secret_scopes

postgres_{projects,branches,endpoints} cc @pietern

external_locations and secret_scopes are intentional, these are not workspace resources with its own URL. I believe postgres ones too

Now that almost all are here, I like the idea of inverting it into an opt-out for missing ones. Will do as follow-up and address postgres_* as part of upcoming work

denik · 2026-05-27T14:13:07Z

 	"jobs":                    "jobs/%s",
 	"models":                  "ml/models/%s",
 	"model_serving_endpoints": "ml/endpoints/%s",
 	"notebooks":               "#notebook/%s",


q - it's not a resource we have, what does this do?

@simonfaltum you added this per git blame

There's databricks experimental open which can open notebooks, I guess it's needed for that

Yeah - the idea was to have a way in the CLI to open workspace resources / generate URL's, so we can enable agents to easily present what they do to the user

andrewnester · 2026-05-27T14:53:02Z

 	"jobs":                    "jobs/%s",
 	"models":                  "ml/models/%s",
 	"model_serving_endpoints": "ml/endpoints/%s",
 	"notebooks":               "#notebook/%s",


There's databricks experimental open which can open notebooks, I guess it's needed for that

eng-dev-ecosystem-bot · 2026-05-27T18:47:46Z

Commit: b85b937

Run: 26523214530

## Changes Move the 11 inline resource URL builders (`catalogs`, `schemas`, `volumes`, `database_catalogs`, `database_instances`, `postgres_catalogs`, `postgres_synced_tables`, `quality_monitors`, `synced_database_tables`, `vector_search_endpoints`, `vector_search_indexes`) onto `workspaceurls.ResourceURL`, joining the ones (`jobs`, `pipelines`, `apps`, ...) that already used it. Each resource's `InitializeURL` is now a one-liner; resource-specific guards (`ModifiedStatus` on `DatabaseInstance`, 3-part name check on `PostgresSyncedTable` and `VectorSearchIndex`) stay in the resource. The new patterns and `dotSeparatedResources` flags live in `libs/workspaceurls/urls.go`, which also drives the `experimental open` command — its supported-type list grows from 13 to 24. Acceptance snapshot for `experimental/open` regenerated to match. One behaviour delta on `postgres_synced_tables` / `vector_search_indexes` pre-deploy: the previous `strings.Cut`-twice logic produced a malformed URL like `[DATABRICKS_URL]/explore/data/$%7Bresources/postgres_catalogs/my_catalog.catalog_id%7D.public.trips_synced` when the name still contained an unresolved `${resources.X.Y}` reference. The new strict 3-part check leaves the URL empty, so summary now renders `(not deployed)` — matching how `database_instances` (and others) already report pre-deploy state. ## Why Two parallel implementations of the same idea drift over time. Putting every resource's URL on the same lookup means future additions only touch one map, and tests like `TestBundleResourcePluralNamesResolveInWorkspaceURLs` (extended here) can fail loudly when a bundle plural name or pattern key drifts. ## Tests - `go test ./libs/workspaceurls/ ./bundle/config/ ./bundle/config/resources/ ./bundle/config/mutator/ ./cmd/experimental/` — green - `./task lint` — 0 issues - `./task fmt`, `./task checks` — clean - Acceptance: `TestAccept/bundle/resources/...`, `TestAccept/bundle/summary/...`, `TestAccept/experimental/open` all green. Regenerated: - `acceptance/experimental/open/output.txt` (expanded supported-type list) - `acceptance/bundle/resources/postgres_synced_tables/basic/output.txt` (URL → `(not deployed)` pre-deploy) _This pull request was written by Claude Code._

janniklasrose temporarily deployed to test-trigger-is May 27, 2026 12:53 — with GitHub Actions Inactive

janniklasrose force-pushed the janniklasrose/centralise-url-handling branch from 292cd74 to 6d3a879 Compare May 27, 2026 13:44

janniklasrose temporarily deployed to test-trigger-is May 27, 2026 13:45 — with GitHub Actions Inactive

janniklasrose marked this pull request as ready for review May 27, 2026 13:49

janniklasrose requested review from denik, pietern and simonfaltum May 27, 2026 13:49

NEXT_CHANGELOG: experimental open supports every URL-bearing resource

aadde2a

Co-authored-by: Isaac

janniklasrose temporarily deployed to test-trigger-is May 27, 2026 13:57 — with GitHub Actions Inactive

denik approved these changes May 27, 2026

View reviewed changes

andrewnester approved these changes May 27, 2026

View reviewed changes

simonfaltum approved these changes May 27, 2026

View reviewed changes

janniklasrose added this pull request to the merge queue May 27, 2026

Merged via the queue into main with commit b85b937 May 27, 2026
36 of 37 checks passed

janniklasrose deleted the janniklasrose/centralise-url-handling branch May 27, 2026 16:06

		@@ -123,15 +123,26 @@ func TestBundleResourcePluralNamesResolveInWorkspaceURLs(t *testing.T) {
		withURLs := []string{

Conversation

janniklasrose commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Changes

Why

Tests

Uh oh!

eng-dev-ecosystem-bot commented May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andrewnester May 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

eng-dev-ecosystem-bot commented May 27, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

janniklasrose commented May 27, 2026 •

edited

Loading

eng-dev-ecosystem-bot commented May 27, 2026 •

edited

Loading

andrewnester May 27, 2026 •

edited

Loading