bundle: rename use_deployment_metadata_service to experimental.record_deployment_history#5397
Merged
Merged
Conversation
denik
approved these changes
Jun 1, 2026
…_deployment_history Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
force-pushed
the
shreyas-goenka/cli-dms-experimental
branch
from
87f3999 to
b0a39ef
Compare
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
added a commit
that referenced
this pull request
Jun 1, 2026
…record_deployment_history When experimental.record_deployment_history is set in databricks.yml, NewDeploymentLock creates a metadataServiceLock alongside the workspace- filesystem lock. Acquire calls DMS CreateVersion after acquiring the file lock; Release calls DMS CompleteVersion before releasing it. Adds the experimental.record_deployment_history config field (matching #5397), its schema annotation, and regenerates jsonschema.json. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
added a commit
that referenced
this pull request
Jun 1, 2026
…record_deployment_history When experimental.record_deployment_history is set in databricks.yml, NewDeploymentLock creates a metadataServiceLock alongside the workspace- filesystem lock. Acquire calls DMS CreateVersion after acquiring the file lock; Release calls DMS CompleteVersion before releasing it. Adds the experimental.record_deployment_history config field (matching #5397), its schema annotation, and regenerates jsonschema.json. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
added a commit
that referenced
this pull request
Jun 1, 2026
…tal.record_deployment_history Adds a deploymentVersionRecorder that records each deploy/destroy as a version with the Deployment Metadata Service (DMS), running alongside the existing workspace-filesystem lock inside DeploymentLock.Acquire / Release. Gated by the experimental.record_deployment_history config field (already on main, #5397). The deployment ID is the state lineage read from resources.json, so a bundle deployment maps one-to-one to a DMS deployment record: - Acquire: after the file lock, GetDeployment(lineage); CreateDeployment only when it does not exist yet; then create the next version (server validates version_id == last_version_id + 1). A heartbeat goroutine keeps the version's lease alive. dstate.GetOrInitLineage generates and stores a lineage on the first deploy so the deploy persists the same value. - Release: complete the version (success/failure); on destroy + success, delete the deployment record. bind/unbind and --force are not supported with DMS. Uses w.Bundle from the Databricks Go SDK directly. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
Collaborator
|
Commit: 33a489c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Renames the
experimental.use_deployment_metadata_serviceconfig field toexperimental.record_deployment_history.Changes:
bundle/config/experimental.go: Go fieldUseDeploymentMetadataService→RecordDeploymentHistory, JSON tag updatedbundle/internal/schema/annotations.yml: key and description updatedbundle/schema/jsonschema.json: regenerated