bundle: add telemetry for workspace.state_path permission scope#5440
Draft
shreyas-goenka wants to merge 1 commit into
Draft
bundle: add telemetry for workspace.state_path permission scope#5440shreyas-goenka wants to merge 1 commit into
shreyas-goenka wants to merge 1 commit into
Conversation
Adds three fields to BundleDeployExperimental: - state_path_scope_exceeds_permissions: state_path is under /Workspace/Shared (all workspace users can read/write) but the permissions section does not grant group_name: users CAN_MANAGE — the effective scope exceeds the declared one. - state_path_is_shared: state_path is under /Workspace/Shared. - state_path_outside_root_path: state_path is not nested under root_path. The signals are computed in a small self-contained helper so this telemetry change is independent of the workspace permission validation mutators. Co-authored-by: Shreyas Goenka <shreyas.goenka@databricks.com>
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
shreyas-goenka
temporarily deployed
to
test-trigger-is
GitHub Actions
Inactive
Collaborator
|
Commit: 82c37e0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds telemetry to detect when
workspace.state_path's permission scope is broader than the bundle's top-levelpermissionssection declares.Three new fields on
BundleDeployExperimental:state_path_scope_exceeds_permissions— state_path is under/Workspace/Shared(all workspace users can read/write) but the permissions section does not grantgroup_name: users CAN_MANAGE, so the effective scope exceeds the declared one.state_path_is_shared— state_path is under/Workspace/Shared.state_path_outside_root_path— state_path is not nested underroot_path.The signals are computed in a small self-contained helper (
statePathScopeSignals), so this change is independent of the workspace permission validation work and can be reviewed and merged on its own.