Use correct hostname and TLS configs#228
Merged
nicklan merged 3 commits intodatabricks:masterfrom Aug 22, 2025
Merged
Conversation
nicklan
reviewed
Aug 22, 2025
Collaborator
nicklan
left a comment
nicklan
left a comment
There was a problem hiding this comment.
one comment, also you need to format the code. I will see if i can fix the clippy warning which will also block you
src/k8s.rs
Outdated
| connect_timeout_secs: u32, | ||
| read_timeout_secs: u32, | ||
| custom_dns_mapping: Option<(String, IpAddr)>, | ||
| tls_server_name: Option<String>, |
Collaborator
There was a problem hiding this comment.
This doesn't seem to actually be used. You pass it around a bunch, and it seemed you wanted to use it in get_client, but for now you're not so maybe we can just remove it?
src/k8s.rs
Outdated
| connect_timeout_secs: u32, | ||
| read_timeout_secs: u32, | ||
| custom_dns_mapping: Option<(String, IpAddr)>, | ||
| _tls_server_name: Option<String>, |
Collaborator
There was a problem hiding this comment.
likewise let's remove this arg
Collaborator
|
also please run |
madeline-shao-db
force-pushed
the
fix-tls-server-name
branch
from
10117e4 to
ffde048
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently click sets the TLS server name as the hostname instead of just using it for TLS verification. Implement a way of specifying a name only for TLS verification through a custom resolver.
Manually tested with
cargo run