Place wheels in content hashed folders when uploading to dbfs instead of renaming them#251
Merged
mukulmurthy merged 6 commits intodatabricks:pipelines-clientfrom Aug 7, 2019
Conversation
Codecov Report
@@ Coverage Diff @@
## pipelines-client #251 +/- ##
====================================================
- Coverage 83.35% 83.34% -0.02%
====================================================
Files 33 33
Lines 2127 2131 +4
====================================================
+ Hits 1773 1776 +3
- Misses 354 355 +1
Continue to review full report at Codecov.
|
mukulmurthy
requested changes
Aug 6, 2019
Collaborator
mukulmurthy
left a comment
mukulmurthy
left a comment
There was a problem hiding this comment.
Do we have a good way of testing what an input path (like whl rel/path.whl) hashes to?
arulajmani
changed the title
arulajmani
changed the title
mukulmurthy
pushed a commit
that referenced
this pull request
Dec 5, 2019
… of renaming them (#251) Change the way we compute the hashed path for wheels. Wheels can't be renamed, so they are put in a folder with the same name as their content hash instead of the rename logic for all other file types.
null-sleep
pushed a commit
that referenced
this pull request
May 18, 2020
… of renaming them (#251) Change the way we compute the hashed path for wheels. Wheels can't be renamed, so they are put in a folder with the same name as their content hash instead of the rename logic for all other file types.
mukulmurthy
pushed a commit
that referenced
this pull request
Jun 1, 2020
… of renaming them (#251) Change the way we compute the hashed path for wheels. Wheels can't be renamed, so they are put in a folder with the same name as their content hash instead of the rename logic for all other file types.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change the way we compute the hashed path for wheels. Wheels can't be renamed, so they are put in a folder with the same name as their content hash instead of the rename logic for all other file types.