Add/Fix support for maven deps in pipelines spec#299
Conversation
| BUFFER_SIZE = 1024 * 64 | ||
| base_pipelines_dir = 'dbfs:/pipelines/code' | ||
| supported_lib_types = {'jar', 'whl'} | ||
| supported_lib_types = {'jar', 'whl', 'maven'} |
There was a problem hiding this comment.
add egg here as well?
There was a problem hiding this comment.
When we did python before we had a good reason for not supporting eggs. I don't remember exactly what that was, but we can do it in the future when it's needed.
null-sleep
force-pushed
the
dhruv/add-support-for-maven-deps
branch
from
314017c to
a5ae253
Compare
Codecov Report
@@ Coverage Diff @@
## pipelines-client #299 +/- ##
====================================================
+ Coverage 84.60% 84.62% +0.01%
====================================================
Files 35 35
Lines 2391 2394 +3
====================================================
+ Hits 2023 2026 +3
Misses 368 368
Continue to review full report at Codecov.
|
mukulmurthy
left a comment
mukulmurthy
left a comment
There was a problem hiding this comment.
Minor: The coordinates field is supposed to include the version (https://docs.databricks.com/dev-tools/api/latest/libraries.html#mavenlibrary). Can you add some simple version here? We can merge this after
mukulmurthy
left a comment
mukulmurthy
left a comment
There was a problem hiding this comment.
LGTM. I merged your other PR, so can you merge pipelines-client into this PR to make sure everything builds and passes tests together? Can merge this after that.
Previously a pipelines spec with maven dependencies would fail with the error: Error: AttributeError: 'dict' object has no attribute 'decode'. This PR fixes the bugs. Testing: Updated tests and manual testing
3 participants
Previously a pipelines spec with maven dependencies would fail with the error:
Error: AttributeError: 'dict' object has no attribute 'decode'. This PR fixes the bugs.Testing:
Updated tests and manual testing