[SC-71155] Fix TypeError in Pipelines CLI#361
Merged
mukulmurthy merged 2 commits intodatabricks:masterfrom Feb 25, 2021
Merged
Conversation
jon-mio
commented
Feb 25, 2021
|
|
||
| result = CliRunner().invoke(cli.deploy_cli, ['--spec', path, '--pipeline-id', "fake"]) | ||
| assert result.exit_code == 1 | ||
| assert "ValueError" in result.stdout |
Contributor
Author
There was a problem hiding this comment.
weirdly the CliRunner does not include the ValueError exception as an object so we have to check the output directly
Collaborator
There was a problem hiding this comment.
Instead of asserting "ValueError", shouldn't we assert some snippet of that helpful error message?
Contributor
Author
There was a problem hiding this comment.
added more of the msg
Codecov Report
@@ Coverage Diff @@
## master #361 +/- ##
=======================================
Coverage 84.57% 84.57%
=======================================
Files 39 39
Lines 2730 2730
=======================================
Hits 2309 2309
Misses 421 421
Continue to review full report at Codecov.
|
mukulmurthy
approved these changes
Feb 25, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We were indexing by key into a string instead of a dict