Fixed scale column for the getColumns function to match the simba output.#989
Merged
msrathore-db merged 8 commits intoSep 12, 2025
Merged
Conversation
Merged the latest changes from main
shivam2680
reviewed
Sep 11, 2025
shivam2680
reviewed
Sep 11, 2025
shivam2680
reviewed
Sep 11, 2025
Merged latest changes from main
shivam2680
reviewed
Sep 12, 2025
shivam2680
reviewed
Sep 12, 2025
shivam2680
approved these changes
Sep 12, 2025
Collaborator
shivam2680
left a comment
shivam2680
left a comment
There was a problem hiding this comment.
lgtm with minor comments.
Collaborator
|
add nextchangelog as well before merging |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the DECIMAL_DIGITS column to return non zero values for timestamp, decimal, numeric datatype. For the rest of the datatypes, the value returned is zero.
Testing
Added unit tests
Additional Notes to the Reviewer
PECOBLR-840
Fixes #960