Skip to content

Add test for GetWorkspaceClient with SPOG host #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
hectorcast-db wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Add test for GetWorkspaceClient with SPOG host #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a21367e
Fix GetWorkspaceClient to clone config for unified hosts
hectorcast-db Mar 19, 2026
74b5010
Add test for GetWorkspaceClient with SPOG host
hectorcast-db Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions databricks-sdk-java/src/main/java/com/databricks/sdk/AccountClient.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

36 changes: 36 additions & 0 deletions databricks-sdk-java/src/test/java/com/databricks/sdk/AccountClientTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,4 +72,40 @@ public void testGetWorkspaceClientForUnifiedHostType() {

assertEquals(HostType.UNIFIED, config.getHostType());
}

@Test
public void testGetWorkspaceClientForSpogHostDoesNotMutateAccountConfig() {
String spogHost = "https://mycompany.databricks.com";
DatabricksConfig accountConfig =
new DatabricksConfig()
.setHost(spogHost)
.setExperimentalIsUnifiedHost(true)
.setAccountId("test-account")
.setToken("test-token");

AccountClient accountClient = new AccountClient(accountConfig);

// Get workspace client for first workspace
Workspace workspace1 = new Workspace();
workspace1.setWorkspaceId(111L);
workspace1.setDeploymentName("ws-1");
WorkspaceClient wc1 = accountClient.getWorkspaceClient(workspace1);

// Get workspace client for second workspace
Workspace workspace2 = new Workspace();
workspace2.setWorkspaceId(222L);
workspace2.setDeploymentName("ws-2");
WorkspaceClient wc2 = accountClient.getWorkspaceClient(workspace2);

// Each workspace client should have its own workspace ID
assertEquals("111", wc1.config().getWorkspaceId());
assertEquals("222", wc2.config().getWorkspaceId());

// Account config should not have been mutated
assertNull(accountConfig.getWorkspaceId());

// Both should share the same SPOG host
assertEquals(spogHost, wc1.config().getHost());
assertEquals(spogHost, wc2.config().getHost());
}
}
Loading