ci(integration-tests): post per-mode Python Proxy Tests checks#811
Merged
Conversation
The proxy-test suite in databricks-driver-test is now a
`mode: [thrift, kernel]` matrix that posts two named check runs per
dispatch: `Python Proxy Tests / thrift` and `Python Proxy Tests /
kernel` (see databricks-driver-test#369). The single unsuffixed
`Python Proxy Tests` check is no longer posted by the matrix legs,
so the synthetic-success / auto-pass / dispatch-failure stanzas in
this workflow must fan out to both names — otherwise the
required-status-check entry `Python Proxy Tests` would still expect
the unsuffixed name but no workflow would post it.
The `MODES` constant at the top of each script is the single source
of truth for the matrix axis; keep it in sync with the matrix in
databricks-driver-test/.github/workflows/python-proxy-tests.yml.
Rollout order:
1. Land databricks-driver-test#369. Matrix legs start posting the
suffixed names. The legacy `Python Proxy Tests` required check
is still satisfied by this workflow's existing single
synthetic-success path (this PR is not merged yet), so PRs
continue to pass.
2. Land this PR AND update branch protection on `main` to swap the
required-status entry `Python Proxy Tests` for both
`Python Proxy Tests / thrift` and `Python Proxy Tests / kernel`.
Order between these two is fine either way — the broken window
is just the time between them. Do them together to minimise it.
Co-authored-by: Isaac
Signed-off-by: Vikrant Puppala <vikrant.puppala@databricks.com>
vikrantpuppala
force-pushed
the
ci/python-proxy-tests-matrix-checks
branch
from
fdf334f to
4ae6c06
Compare
vikrantpuppala
had a problem deploying
to
azure-prod
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The proxy-test suite in
databricks-driver-testis now amode: [thrift, kernel]matrix that posts two named check runs per dispatch:Python Proxy Tests / thriftandPython Proxy Tests / kernel(seedatabricks-driver-test#369). The single unsuffixedPython Proxy Testscheck is no longer posted by the matrix legs.Without this PR, the synthetic-success / auto-pass / dispatch-failure stanzas in
trigger-integration-tests.ymlwould still post the legacy unsuffixedPython Proxy Testsname. When branch protection is flipped to require the two suffixed names, the synthetic baseline would disappear and every connector PR that doesn't actually dispatch the suite (i.e. most of them) would block forever on a missing required check.This PR fans every check-posting step out to both modes. The
MODESconstant at the top of each script is the single source of truth for the matrix axis; keep it in sync with the matrix indatabricks-driver-test/.github/workflows/python-proxy-tests.yml.What changes
5 places in
trigger-integration-tests.ymlnow loop over['thrift', 'kernel']instead of posting a singlePython Proxy Testscheck:skip-integration-tests-pr— synthetic-success on PR open / push / non-IT label.trigger-tests-pr"Pass Python Proxy Tests check (no driver changes)" — auto-pass when the label is added but no driver files changed.trigger-tests-pr"Fail check on dispatch error" — failure synthetic when dispatch errors.merge-queue-python"Auto-pass (no driver changes)" — merge-queue auto-pass.merge-queue-python"Fail check on dispatch error" — merge-queue dispatch failure.The top-of-file comment block is updated to document the new check names and the rollout order.
Rollout order
databricks-driver-test#369first. The matrix legs start posting the suffixed names. The legacyPython Proxy Testsrequired check is still satisfied by this workflow's existing single-synthetic-success path (this PR is not merged yet), so PRs continue to pass.mainto replace the required-status entryPython Proxy Testswith bothPython Proxy Tests / thriftandPython Proxy Tests / kernel. Order between these two is fine either way — the window of brokenness is just the time between them. Do them together to minimise it.Test plan
actionlintparity — comment-block + script-block edits only, no structural changes).skip-integration-tests-prposts two suffixed synthetic checks (Python Proxy Tests / thrift,Python Proxy Tests / kernel) and the legacy unsuffixed check no longer appears.This pull request and its description were written by Isaac.