feat(bots): reviewer-bot live workflows (review + follow-up)#828
Closed
eric-wang-1990 wants to merge 1 commit into
Closed
feat(bots): reviewer-bot live workflows (review + follow-up)#828eric-wang-1990 wants to merge 1 commit into
eric-wang-1990 wants to merge 1 commit into
Conversation
Third of the stacked reviewer-bot migration. Adds the live workflows that run
the bot on PRs:
- reviewer-bot.yml — reviews on pull_request (opened/synchronize/reopened/
ready_for_review) + manual workflow_dispatch (dry-run capable). Fork-guarded;
protected runner; mints a peco-review-bot App token; setup-claude-sdk for the
SDK/CLI install. Reads/explores the PR's own checkout (no driver clone).
- reviewer-bot-followup.yml — responds to pull_request_review_comment with the
cheap pre-checkout filter + the marker-based loop guards.
Adapted from the driver-test workflows: removed the driver-repo clone auth
(INTEGRATION_TEST_APP_TOKEN — N/A here) and made MODEL_ENDPOINT a secret rather
than a hardcoded workspace URL.
PREREQS (these workflows stay inert until provided):
- peco-review-bot GitHub App installed on this repo (Pull requests / Issues /
Contents: Read & Write).
- Secrets: REVIEW_BOT_APP_ID, REVIEW_BOT_APP_PRIVATE_KEY, MODEL_ENDPOINT;
DATABRICKS_TOKEN authorized for that serving endpoint.
Co-authored-by: Isaac
Signed-off-by: Eric Wang <e.wang@databricks.com>
eric-wang-1990
had a problem deploying
to
azure-prod
GitHub Actions
Failure
Author
|
Superseded by #834 — recreated under gitstack management (clean |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Third and final PR of the stacked reviewer-bot migration (stacked on #827). Adds the live workflows that run the bot on PRs.
Workflows
reviewer-bot.yml— reviews onpull_request(opened/synchronize/reopened/ready_for_review) + manualworkflow_dispatch(dry-run capable). Fork-guarded; protected runner; mints a peco-review-bot App token;setup-claude-sdkfor the SDK/CLI install. Reads/explores the PR's own checkout (no driver clone).reviewer-bot-followup.yml— responds topull_request_review_commentwith the cheap pre-checkout filter + marker-based loop guards.Adapted from the driver-test workflows: removed the driver-repo clone auth (
INTEGRATION_TEST_APP_TOKEN, N/A here) and madeMODEL_ENDPOINTa secret rather than a hardcoded workspace URL.databricks/databricks-sql-python(Pull requests / Issues / Contents: Read & Write).REVIEW_BOT_APP_ID,REVIEW_BOT_APP_PRIVATE_KEY,MODEL_ENDPOINT(the Claude serving-endpoint URL); confirmDATABRICKS_TOKENis authorized for that endpoint.Verify (after prereqs)
workflow_dispatchwithdry_run=trueagainst a sample PR → the bot prints the findings + summary it would post (no writes). Then a livepull_requestreview.Recommended landing order
Land #826 → #827 → this. (Stacked; each rebases onto
mainas the one below merges.)This pull request and its description were written by Isaac.