docs: add explicit functional vs unit test scope rules to AGENTS.md#1422
Merged
Conversation
sd-db
force-pushed
the
sd-db/docs/agents-md-test-scope-rules
branch
2 times, most recently
from
da91ceb to
f10cdfa
Compare
The split was conveyed only through examples (functional tests assert row counts; macro unit tests use assert_sql_equal), and a contributor could reasonably put specific-warning or compiled-SQL assertions in a functional test without tripping any review signal. Adds three short sentences stating the principle (functional = outcomes, unit = specifics), the litmus (would the assertion survive a future release that ships the same behavior via different SQL?), and a note that trivial macro additions do not need a test. Co-authored-by: Isaac
sd-db
force-pushed
the
sd-db/docs/agents-md-test-scope-rules
branch
from
f10cdfa to
15822a2
Compare
tejassp-db
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Makes the unit vs functional test split explicit in AGENTS.md. The current section distinguishes the two by where they live and how they run, but the rule for what each type should assert was conveyed only through examples. A contributor could reasonably put specific-warning or compiled-SQL assertions in a functional test without tripping any review signal (surfaced in #1421 review).
Adds two short paragraphs: the principle (functional = outcomes, unit = specifics) and a note that trivial macro additions do not need a test.
Checklist
CHANGELOG.mdand added information about my change to the "dbt-databricks next" section.