Skip to content

Use single quotes in gets in templates#889

Merged
benc-db merged 1 commit intomainfrom
use_consistent_quotes
Dec 20, 2024
Merged

Use single quotes in gets in templates#889
benc-db merged 1 commit intomainfrom
use_consistent_quotes

Conversation

@benc-db
Copy link
Copy Markdown
Collaborator

@benc-db benc-db commented Dec 20, 2024

Description

Discovered when I was trying to add a new config entry that:

config.get('foo')

and

config.get("foo")

behave differently in Jinja templates. This is crazy. I believe this only applies to the config dictionary, but to be safe, every place we use get in the templates, I want to use single quotes.

Checklist

  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have updated the CHANGELOG.md and added information about my change to the "dbt-databricks next" section.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant