Skip to content

Generate 10 minutes to Koalas as documentation#853

Merged
HyukjinKwon merged 1 commit into
databricks:masterfrom
HyukjinKwon:generate-10min-page
Oct 2, 2019
Merged

Generate 10 minutes to Koalas as documentation#853
HyukjinKwon merged 1 commit into
databricks:masterfrom
HyukjinKwon:generate-10min-page

Conversation

@HyukjinKwon
Copy link
Copy Markdown
Member

@HyukjinKwon HyukjinKwon commented Oct 1, 2019

This PR adds our "10 minutes to Koalas" into official documentation. This Binder has the changes made in this PR.

  1. In notebook, ... and >>> are removed now. I initially wanted to use pandoc right away but it couldn't the output properly. Instead, I used nbsphinx that uses nbconvert which uses pandoc. With nbsphinx, ... and >>> are rendered properly (with ipython directive).

  2. Sphinx extension IPython.sphinxext.ipython_console_highlighting and ipython dependency were added in order to recognise ipython3 directive with reStructuredText files and Sphinx.

  3. Added the link to Jupyter notebook (Binder) to the tutorial itself.

Comment thread docs/source/conf.py
'sphinx.ext.viewcode',
'numpydoc', # handle NumPy documentation formatted docstrings. Needs to install
'nbsphinx', # Jupyter Notebook. Needs to install
'nbsphinx', # Converts Jupyter Notebook to reStructuredText files for Sphinx.
Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BTW, pandoc added at #843 seems anyway required. nbsphinx requires nbconvert which requires pandoc.

@softagram-bot
Copy link
Copy Markdown

Softagram Impact Report for pull/853 (head commit: 964eb8e)

⭐ Change Overview

Showing the changed files, dependency changes and the impact - click for full size
(Open in Softagram Desktop for full details)

📄 Full report

Impact Report explained. Give feedback on this report to support@softagram.com

@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 1, 2019

Codecov Report

Merging #853 into master will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #853      +/-   ##
=========================================
+ Coverage   94.17%   94.2%   +0.03%     
=========================================
  Files          32      32              
  Lines        6007    6007              
=========================================
+ Hits         5657    5659       +2     
+ Misses        350     348       -2
Impacted Files Coverage Δ
databricks/koalas/sql.py 97.91% <0%> (+2.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4171024...964eb8e. Read the comment docs.

@HyukjinKwon
Copy link
Copy Markdown
Member Author

I am merging this to show how it looks like in readthedocs. I am still touching documentation so please let me know if you guys have some comments.

@HyukjinKwon HyukjinKwon merged commit fa59f0e into databricks:master Oct 2, 2019
@HyukjinKwon
Copy link
Copy Markdown
Member Author

Here ! https://koalas.readthedocs.io/en/latest/getting_started/10min.html

@HyukjinKwon HyukjinKwon deleted the generate-10min-page branch November 6, 2019 02:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants