Strengthen agent rules from APIError porting learnings#14
Merged
Conversation
This was referenced Feb 27, 2026
Draft
mihaimitrea-db
requested changes
Feb 27, 2026
5238189 to
c92ac91
Compare
mihaimitrea-db
approved these changes
Feb 27, 2026
Co-authored-by: mihaimitrea-db <mihai.mitrea@databricks.com>
bc72883 to
12ad915
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🥞 Stacked PR
Use this link to review incremental changes.
What changes are proposed in this pull request?
Gaps found during the APIError porting PR (#13) where repeated back-and-forth was needed. These rule updates make the expectations explicit so future agents get it right on the first pass.
Unwrap()), factory functions vs constructors (use factory when Go returns nil), no Go references in code or comments.expect.fail()notreturn), test all outputs (don't skip "obvious" fields), use real types for expected values (not anonymous objects), preserve existing test structure (don't rename fields or restructure committed tests).@privateJSDoc pattern for internal methods, API surface minimization (only export fromindex.tswhat consumers need).How is this tested?
N/A — metadata only, no runtime changes.