Skip to content

Stop manifesting functions with no arguments in objects by default#233

Merged
stephenamar-db merged 1 commit intomasterfrom
manifestfn
Dec 12, 2024
Merged

Stop manifesting functions with no arguments in objects by default#233
stephenamar-db merged 1 commit intomasterfrom
manifestfn

Conversation

@stephenamar-db
Copy link
Copy Markdown
Collaborator

This is inline with go-jsonnet's behavior.

This behavior difference made TLA vars working properly in sjsonnet - I moved this part to the interpreter.
This fixes #168

Copy link
Copy Markdown
Contributor

@JoshRosen JoshRosen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Comment thread sjsonnet/src/sjsonnet/Interpreter.scala
@stephenamar-db stephenamar-db merged commit 73b3826 into master Dec 12, 2024
@stephenamar-db stephenamar-db deleted the manifestfn branch December 12, 2024 02:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sjsonnet is more lenient than google/jsonnet in calling 0-argument function values during materialization

2 participants