Skip to content

Comments

chore: support query extVar and tlaVar with a function.#278

Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom
He-Pin:queryVars
Apr 17, 2025
Merged

chore: support query extVar and tlaVar with a function.#278
stephenamar-db merged 1 commit intodatabricks:masterfrom
He-Pin:queryVars

Conversation

@He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Apr 17, 2025

Motivation:
Currently, I'm using sjsonnet from Java, which will require me to convert to Scala's immutable map.

Modification:
Instead of converting, add a query function to look up the value.

Result:
Less overhead when using in Java

@He-Pin He-Pin force-pushed the queryVars branch 3 times, most recently from 61ee61a to 9adc449 Compare April 17, 2025 11:10
@He-Pin
Copy link
Contributor Author

He-Pin commented Apr 17, 2025

Another way is using an asImmutableMap helper method

@stephenamar-db stephenamar-db merged commit 91bd4f4 into databricks:master Apr 17, 2025
6 checks passed
@He-Pin He-Pin deleted the queryVars branch April 18, 2025 02:41
@stephenamar-db
Copy link
Collaborator

This is causing a regression. I'm investigating and I may revert.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants