Skip to content

Comments

chore: add some static optimization#294

Merged
stephenamar-db merged 1 commit intodatabricks:masterfrom
He-Pin:binary
Apr 21, 2025
Merged

chore: add some static optimization#294
stephenamar-db merged 1 commit intodatabricks:masterfrom
He-Pin:binary

Conversation

@He-Pin
Copy link
Contributor

@He-Pin He-Pin commented Apr 20, 2025

Motivation:
Add some static optimization for long run jsonnet script.

@He-Pin He-Pin force-pushed the binary branch 6 times, most recently from a6b9dae to 03f2aab Compare April 20, 2025 14:24
@He-Pin He-Pin changed the title chore: add boolean static optimization chore: add some static optimization Apr 20, 2025
@He-Pin He-Pin force-pushed the binary branch 2 times, most recently from 1f20548 to 3620515 Compare April 20, 2025 14:36
@stephenamar-db
Copy link
Collaborator

Does it actually make a difference?

@He-Pin
Copy link
Contributor Author

He-Pin commented Apr 21, 2025

our use cases is long running jsonnet script ,so It should help in some scenarios.

@stephenamar-db stephenamar-db merged commit 60db9d0 into databricks:master Apr 21, 2025
6 checks passed
stephenamar-db pushed a commit that referenced this pull request Apr 21, 2025
Motivation:
Clean up the code, and then the user can provide a static optimizer,
too.
refs: #294
@He-Pin He-Pin deleted the binary branch April 21, 2025 04:50
stephenamar-db added a commit that referenced this pull request Apr 29, 2025
stephenamar-db added a commit that referenced this pull request Apr 29, 2025
stephenamar-db added a commit that referenced this pull request Apr 29, 2025
stephenamar-db added a commit that referenced this pull request Apr 29, 2025
This partially reverts commit 60db9d0.

This is causing performance regressions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants