Skip to content

feat: Allow negative start/end on std.slice#367

Merged
stephenamar-db merged 2 commits intodatabricks:masterfrom
He-Pin:sliceNeg
May 13, 2025
Merged

feat: Allow negative start/end on std.slice#367
stephenamar-db merged 2 commits intodatabricks:masterfrom
He-Pin:sliceNeg

Conversation

@He-Pin
Copy link
Copy Markdown
Contributor

@He-Pin He-Pin commented May 13, 2025

Motivation:
Fix: refs: #362

Modification:

  1. Port he std.slice method in google/jsonnet to scala
  2. Update the jsonnet test files
  3. Extract the Util.slice method to support both std.slice and the usage in Evaluator.

@He-Pin He-Pin marked this pull request as ready for review May 13, 2025 05:29
@He-Pin
Copy link
Copy Markdown
Contributor Author

He-Pin commented May 13, 2025

Seems like the google/jsonnet is using the std.slice to handle both the evaluation of AST.Slice and std.slice function.

@stephenamar-db stephenamar-db merged commit 4a2de7f into databricks:master May 13, 2025
6 checks passed
@He-Pin He-Pin deleted the sliceNeg branch May 13, 2025 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants