Skip to content

Fix tailstrict implementation and add more tests#379

Merged
stephenamar-db merged 1 commit intomasterfrom
stephenamar-db/stack/ts2
May 14, 2025
Merged

Fix tailstrict implementation and add more tests#379
stephenamar-db merged 1 commit intomasterfrom
stephenamar-db/stack/ts2

Conversation

@stephenamar-db
Copy link
Copy Markdown
Collaborator

Fixes #359

@stephenamar-db
Copy link
Copy Markdown
Collaborator Author

@He-Pin @Danstahrm

@He-Pin
Copy link
Copy Markdown
Contributor

He-Pin commented May 14, 2025

  1. there is a long_chains.jsonnet in google/jsonnet repo
  2. there are more tests about tailstrict in google/go-jsonnet repo, eg tailstrict_operator2.jsonnet

We can includes both here too.

@stephenamar-db
Copy link
Copy Markdown
Collaborator Author

I can get long_chains to pass, but let's add it to a future bench suite.

~/sjsonnet % JAVA_OPTS="-Xss500m" out/sjsonnet/jvm/3.3.6/assembly.dest/out.jar long_chains.jsonnet                                                                  
true

@stephenamar-db stephenamar-db force-pushed the stephenamar-db/stack/ts2 branch from c954f2c to 0a463c2 Compare May 14, 2025 18:52
@stephenamar-db stephenamar-db force-pushed the stephenamar-db/stack/ts2 branch from 0a463c2 to ad00587 Compare May 14, 2025 18:53
@stephenamar-db stephenamar-db requested a review from He-Pin May 14, 2025 18:53
@stephenamar-db stephenamar-db merged commit ad5ae74 into master May 14, 2025
6 checks passed
@stephenamar-db stephenamar-db deleted the stephenamar-db/stack/ts2 branch May 14, 2025 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Tailstrict should only apply to the function, not to the whole evaluator

2 participants