fix(js,native): std.parseYaml() handling of "---". #447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
He-Pin
reviewed
Jun 24, 2025
rudo-thomas
force-pushed
the
rudo-thomas/fix-std.parseYaml
branch
from
6680c5b to
583f580
Compare
Problem: On js and native targets std.parseYaml() mishandles input where "---" is not at the beginning of the line. (The jvm target is fine.) Fix: Only match "---" at the beginning of the line. Also don't require a newline after it. Note that there are other corner cases that are still broken, but for those I'll file a bug against the underlying scala-yaml library.
rudo-thomas
force-pushed
the
rudo-thomas/fix-std.parseYaml
branch
from
583f580 to
db47c30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: On js and native targets std.parseYaml() mishandles input where "---" is not at the beginning of the line. (The jvm target is fine.)
Fix: Only match "---" at the beginning of the line. Also don't require a newline after it.
Note that there are other corner cases that are still broken, but for those I'll file a bug against the underlying scala-yaml library.