Fix incorrect capture of pip output in verbose mode#332
Merged
Conversation
Verbose-mode was broken due to the incorrect value for stdout being passed.
|
❌ 37/40 passed, 3 failed, 2 skipped, 1m57s total ❌ test_upload_dbfs: subprocess.CalledProcessError: Command '['/home/runner/work/blueprint/blueprint/.venv/bin/python', '-m', 'pip', 'wheel', '--wheel-dir', '/tmp/tmpkwedvs53', '/tmp/tmpkwedvs53/working-copy', '--no-deps']' returned non-zero exit status 1. (10.376s)❌ test_upload_wsfs: subprocess.CalledProcessError: Command '['/home/runner/work/blueprint/blueprint/.venv/bin/python', '-m', 'pip', 'wheel', '--wheel-dir', '/tmp/tmpwk7r9d0n', '/tmp/tmpwk7r9d0n/working-copy', '--no-deps']' returned non-zero exit status 1. (10.413s)❌ test_upload_upstreams: subprocess.CalledProcessError: Command '['/home/runner/work/blueprint/blueprint/.venv/bin/python', '-m', 'pip', 'wheel', '--wheel-dir', '/tmp/tmpwk39ww0q', '/tmp/tmpwk39ww0q/working-copy', '--no-deps']' returned non-zero exit status 1. (8.768s)Running from acceptance #429 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes a minor bug encountered while trying to diagnose failures with the builtin wheel-building mechanism. When the
verbose-flag was enabled, the pip command was not invoked properly (and would fail immediately) becausesubprocess.STDOUTis only valid for thestderrargument: forstdoutit must instead beNonefor the output to be passed through.