Skip to content

🚑️ Fix parsing logic for named parameters in Jobs API 2.1 Asset-based launch#771

Merged
renardeinside merged 3 commits intomainfrom
bugfix/named-params-passing
May 10, 2023
Merged

🚑️ Fix parsing logic for named parameters in Jobs API 2.1 Asset-based launch#771
renardeinside merged 3 commits intomainfrom
bugfix/named-params-passing

Conversation

@renardeinside
Copy link
Copy Markdown
Contributor

Proposed changes

Addresses #752

Types of changes

What types of changes does your code introduce to dbx?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Further comments

If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...

@codecov
Copy link
Copy Markdown

codecov Bot commented May 10, 2023

Codecov Report

Merging #771 (94bbbc5) into main (b0dfd87) will not change coverage.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##             main     #771   +/-   ##
=======================================
  Coverage   93.69%   93.69%           
=======================================
  Files          98       98           
  Lines        3840     3840           
  Branches      483      483           
=======================================
  Hits         3598     3598           
  Misses        184      184           
  Partials       58       58           
Impacted Files Coverage Δ
dbx/__init__.py 100.00% <100.00%> (ø)
dbx/models/workflow/v2dot1/_parameters.py 100.00% <100.00%> (ø)

@renardeinside renardeinside merged commit 1771390 into main May 10, 2023
@renardeinside renardeinside deleted the bugfix/named-params-passing branch May 10, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

named_parameters are ignored when launching workflows in assets-based mode

1 participant